Skip to content

quarto mod 6 #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 2, 2025
Merged

quarto mod 6 #50

merged 5 commits into from
Jun 2, 2025

Conversation

zmx721
Copy link
Contributor

@zmx721 zmx721 commented Apr 29, 2025

@joelostblom Here is the PR for Module 6. Please check if we want to specify more CSS styles for sk-container used in module6_10.qmd.

@zmx721 zmx721 requested a review from joelostblom April 29, 2025 23:15
Copy link

github-actions bot commented Apr 29, 2025

PR Preview Action v1.6.1
Preview removed because the pull request was closed.
2025-06-02 07:41 UTC

@joelostblom
Copy link
Collaborator

Please check if we want to specify more CSS styles for sk-container used in module6_10.qmd.

I think ideally they would not have a black background, but I'm OK for now and we can follow up in #53

@zmx721
Copy link
Contributor Author

zmx721 commented Jun 2, 2025

@sandygross Thank you for your review. I have fixed the issues according to your comments.

Copy link
Collaborator

@joelostblom joelostblom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renders fine with the latest changes, merging.

@joelostblom joelostblom merged commit 7c1582a into main Jun 2, 2025
1 check passed
@joelostblom joelostblom deleted the quarto_mod6 branch June 2, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants